Security Digest · Critical advisory (no CVE assigned)
GHSA-hff9-5pqw-6w9f: imgproxy has integer overflow in imgproxy ICO loader that causes denial of service and may permit remote code execution
Summary The ICO loader allocates datasize + BMPFILEHEADERLEN bytes after reading a 32-bit attacker-controlled datasize.
CVSS 9.8 Critical GitHub-reviewed · critical
Should you act?
- Only if you depend on one of the packages below, directly or transitively, in a vulnerable version. Check your lockfile with
govulncheck ./.... - No CVE has been assigned, so it will not appear in CVE-based scanners that ignore GitHub advisories.
npm audit,pip-auditand Dependabot do read GitHub advisories.
Affected packages
| Ecosystem | Package | Vulnerable | First fixed |
|---|---|---|---|
| Go | github.com/imgproxy/imgproxy/v3 | >= 4.0.0, < 4.0.16 | 4.0.16 |
| Go | github.com/imgproxy/imgproxy/v2 | >= 4.0.0, < 4.0.16 | 4.0.16 |
| Go | github.com/imgproxy/imgproxy | >= 4.0.0, < 4.0.16 | 4.0.16 |
Details
Summary
The ICO loader allocates datasize + BMPFILEHEADERLEN bytes after reading a 32-bit attacker-controlled datasize. For datasize > UINT32MAX - BMPFILEHEADERLEN, the addition wraps before allocation. imgproxy then writes the ICO prefix and reads up to the original declared size starting 14 bytes into the undersized allocation. A network client can turn this heap overflow into remote denial of service or remote code execution.
Technical details
The vulnerable path is in vips/icoload.c at commit f4fedbb:
The crafted directory entry contains:
The allocation is therefore three bytes. actualdata points 14 bytes after the allocation base. The fixture contains 64 bytes after the ICO header, so the source callback copies those 64 bytes to an invalid destination before it can report that the declared multi-gigabyte payload is incomplete.
The complete source-to-sink path is:
1. Attacker-controlled bytes begin with the ICO magic 00 00 01 00. 2. imgproxy identifies the source as ICO and dispatches it to vipsicoloadsourcego. 3. vipsforeignloadicoheader reads the attacker-controlled datasize. 4. The 32-bit addition wraps, and VIPSMALLOC receives the value three. 5. vipsforeignloadreadfull passes the original datasize to the Go source callback. 6. The callback writes the available source bytes through the invalid pointer, corrupting the process heap.
CVSS: 9.8 (v3.1) CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:H/I:H/A:H
Sources and references
- GitHub Advisory GHSA-hff9-5pqw-6w9f github.com
- github.com github.com
- github.com github.com
- github.com github.com